Skip to content

[FrameworkBundle] Command cache:pool:clear warns and fails when one of the pools fails to clear #39910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2021
Merged

[FrameworkBundle] Command cache:pool:clear warns and fails when one of the pools fails to clear #39910

merged 1 commit into from
Jan 26, 2021

Conversation

jderusse
Copy link
Member

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets fix #39890
License MIT
Doc PR -

Throw an exception when clear cache fails

@jderusse jderusse added this to the 5.x milestone Jan 20, 2021
@carsonbot carsonbot changed the title Throw exception when clear failed [FrameworkBundle] Throw exception when clear failed Jan 20, 2021
@jderusse jderusse force-pushed the cache-clear-error branch 2 times, most recently from 13c969f to 172da6b Compare January 25, 2021 09:16
@nicolas-grekas
Copy link
Member

(failure on Windows)

@jderusse jderusse force-pushed the cache-clear-error branch 2 times, most recently from f36d2d0 to 07764c0 Compare January 26, 2021 12:13
@jderusse
Copy link
Member Author

(failure on Windows)

test refactored to be compatible with windows

@jderusse jderusse changed the title [FrameworkBundle] Throw exception when clear failed [FrameworkBundle] Command cache:pool:clear warns and fails when one of the pools fails to clear Jan 26, 2021
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas mentioned this pull request Jan 26, 2021
Closed
@nicolas-grekas nicolas-grekas merged commit 8e90a80 into symfony:5.x Jan 26, 2021
@jderusse jderusse deleted the cache-clear-error branch January 27, 2021 10:43
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

cache:pool:clear never fails on permission errors
4 participants
@jderusse @nicolas-grekas @OskarStark @carsonbot