[RateLimiter] Fix infinite values with NoLimiter #39911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e8376e1 to
4f9eedf
Compare
OskarStark
reviewed
Jan 20, 2021
| @@ -29,12 +29,12 @@ final class NoLimiter implements LimiterInterface | |||
| { | |||
| public function reserve(int $tokens = 1, ?float $maxTime = null): Reservation | |||
| { | |||
| return new Reservation(time(), new RateLimit(\INF, new \DateTimeImmutable(), true, \INF)); | |||
There was a problem hiding this comment.
I am not into the code nor the component, but couldn't we use "-1" like for example done in memory_limit setting in PHP instead of a very large number? 🧐
cc @wouterj
There was a problem hiding this comment.
Currently the only use of the remainingTokens and limit properties is for the developer to know how many requests the user can send. This is not used internally in the RateLimiter component.
nicolas-grekas
approved these changes
Jan 23, 2021
|
Thank you @YaFou. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #39899. I don't find any solution to convert
\INFconstant (which is a float value) to an integer.