Skip to content

[Validator] Fix DebugCommand #39936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2021
Merged

[Validator] Fix DebugCommand #39936

merged 1 commit into from
Jan 23, 2021

Conversation

loic425
Copy link
Contributor

@loic425 loic425 commented Jan 22, 2021

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@carsonbot carsonbot added this to the 5.2 milestone Jan 22, 2021
@carsonbot carsonbot changed the title [WIP][Validator] Fix DebugCommand [Validator] [WIP] Fix DebugCommand Jan 22, 2021
@loic425 loic425 force-pushed the fix/debug-validator-command branch 2 times, most recently from 636fe72 to 6c3e48a Compare January 22, 2021 10:02
@loic425 loic425 changed the title [Validator] [WIP] Fix DebugCommand [Validator] Fix DebugCommand Jan 22, 2021
@loic425 loic425 force-pushed the fix/debug-validator-command branch from 71fca52 to b6fef86 Compare January 22, 2021 10:52
@OskarStark
Copy link
Contributor

Can you please tell what is the bug about you are trying to fix? Thanks

@loic425
Copy link
Contributor Author

loic425 commented Jan 22, 2021

Can you please tell what is the bug about you are trying to fix? Thanks

It crashes when debuging validators in a directory path which contains other files than classes but with namespace (traits, interfaces). I will edit the first post with the error.

@xabbuh
Copy link
Member

xabbuh commented Jan 23, 2021

Does it apply to the 4.4 branch too?

@loic425
Copy link
Contributor Author

loic425 commented Jan 23, 2021 •
edited
Loading

Does it apply to the 4.4 branch too?

No this feature was released on 5.2 :)
https://symfony.com/doc/current/validation.html#debugging-the-constraints

@nicolas-grekas nicolas-grekas force-pushed the fix/debug-validator-command branch from be78ef1 to 1eb1376 Compare January 23, 2021 18:47
@nicolas-grekas
Copy link
Member

Thank you @loic425.

@nicolas-grekas nicolas-grekas merged commit b4c362c into symfony:5.2 Jan 23, 2021
@loic425 loic425 deleted the fix/debug-validator-command branch January 24, 2021 01:19
@fabpot fabpot mentioned this pull request Jan 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Validator
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@loic425 @OskarStark @xabbuh @nicolas-grekas @carsonbot