Skip to content

[Notifier] [SpotHit] Add the bridge #39948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2021
Merged

[Notifier] [SpotHit] Add the bridge #39948

merged 1 commit into from
Feb 3, 2021

Conversation

JamesHemery
Copy link
Contributor

@JamesHemery JamesHemery commented Jan 23, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#14869
Recipe PR symfony/recipes#881

@OskarStark Bridge added :)

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@JamesHemery JamesHemery changed the title [Notifier] Spot-Hit bridge [Notifier][SpotHit] Add the bridge Jan 23, 2021
@nicolas-grekas nicolas-grekas added this to the 5.x milestone Jan 23, 2021
OskarStark
OskarStark reviewed Jan 25, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor last comments

@OskarStark
Copy link
Contributor

@JamesHemery open to finish this PR? 😃

@OskarStark
Copy link
Contributor

One last comment, lets name name package symfony/spothit-notifer please, same for docs and recipe, afterwards good to go 👍

@carsonbot carsonbot changed the title [Notifier][SpotHit] Add the bridge [Notifier] [SpotHit] Add the bridge Feb 2, 2021
@OskarStark
Copy link
Contributor

Thanks James for working on this feature, this is much appreciated.

@OskarStark OskarStark merged commit 3eb8a42 into symfony:5.x Feb 3, 2021
@JamesHemery JamesHemery deleted the spothit-notifier branch February 4, 2021 10:45
@fabpot
Copy link
Member

fabpot commented Feb 14, 2021

FYI, I've fixed the package name in #40186

@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr

@xabbuh xabbuh Awaiting requested review from xabbuh

@fabpot fabpot Awaiting requested review from fabpot

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@JamesHemery @carsonbot @OskarStark @fabpot @derrabus @nicolas-grekas