Skip to content

[Mailer][Mime] Fix case-sensitive handling of header names #39954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

piku235
Copy link
Contributor

@piku235 piku235 commented Jan 23, 2021

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39953
License MIT
Doc PR -

Fixes case-sensitive handling of header names in "Mime" and "Mailer" component, more in the ticket.

@carsonbot carsonbot changed the title [Mime][Mailer] Fix case-sensitive handling of header names [Mime] [Mailer] Fix case-sensitive handling of header names Jan 23, 2021
@carsonbot carsonbot added this to the 5.2 milestone Jan 23, 2021
@carsonbot carsonbot changed the title [Mime] [Mailer] Fix case-sensitive handling of header names [Mailer][Mime] Fix case-sensitive handling of header names Jan 23, 2021
@carsonbot
Copy link

Hey!

Nice work here, I this makes me happy.

I think @scuben has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 4.4 affected? Is yes, can you change the target to 4.4 instead? Thank you.

@piku235
Copy link
Contributor Author

piku235 commented Feb 1, 2021

The commits f1bcece and 70f703d depend on the v5.2, they relate to #36736.

The commit 0a91e7f fixes Headers::isUnique() which exists since the very beginning of the symfony/mime component (introduced in v4.3), so it exists also for v4.4. I guess there's no need to do it for v4.3 as it's not maintained anymore.
I think we can create a separate PR targeting v4.4 and cherry-pick this commit (with small update), what do you think?

@fabpot
Copy link
Member

fabpot commented Feb 1, 2021

Let's create a PR for 4.4.

@piku235
Copy link
Contributor Author

piku235 commented Feb 1, 2021

Ok, done #40062.

fabpot added a commit that referenced this pull request Feb 2, 2021
This PR was merged into the 4.4 branch.

Discussion
----------

[Mime] Fix case-sensitive handling of header names

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39953
| License       | MIT
| Doc PR        | -

Fixes case-sensitive handling of header names in "Mailer" component, more in the [ticket](#39953) and the [root PR](#39954).

Commits
-------

b2d7454 [Mime] Fix case-sensitive handling in Headers::isUniqueHeader()
@fabpot
Copy link
Member

fabpot commented Feb 2, 2021

Thank you @piku235.

@fabpot fabpot merged commit cedcb55 into symfony:5.2 Feb 2, 2021
@fabpot fabpot mentioned this pull request Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants