Skip to content

[Console] Fix typo in console.command description #39964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2021
Merged

[Console] Fix typo in console.command description #39964

merged 1 commit into from
Jan 26, 2021

Conversation

oceanicpanda
Copy link
Contributor

@oceanicpanda oceanicpanda commented Jan 25, 2021 •
edited by derrabus
Loading

input and output can be handed to the command, handed off to the command, or can be handled by the command, but handled to the command doesn't work

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A

@oceanicpanda oceanicpanda requested a review from chalasr as a code owner January 25, 2021 14:57
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

derrabus
derrabus approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 4.4

@derrabus derrabus added this to the 4.4 milestone Jan 26, 2021
@carsonbot carsonbot changed the title Update ConsoleEvents.php [Console] Update ConsoleEvents.php Jan 26, 2021
@derrabus derrabus changed the title [Console] Update ConsoleEvents.php [Console] Fix typo in console.command description Jan 26, 2021
@oceanicpanda @derrabus
Update ConsoleEvents.php
38fd86f 
input and output can be handed to the command, handed off to the command, or can be handled by the command, but handled to the command doesn't work
@derrabus derrabus changed the base branch from 5.x to 4.4 January 26, 2021 08:54
@derrabus
Copy link
Member

Good catch, thanks @oceanicpanda.

@derrabus derrabus merged commit d244e79 into symfony:4.4 Jan 26, 2021
@oceanicpanda oceanicpanda deleted the patch-1 branch January 26, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Console Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@oceanicpanda @carsonbot @derrabus @OskarStark