[Uid] Replace getTime() with getDateTime() #40008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2bfcbe to
df032e7
Compare
fancyweb
commented
Jan 27, 2021
| @@ -95,7 +95,7 @@ public function testV6() | |||
|
|
|||
| $uuid = new UuidV6(substr_replace(self::A_UUID_V1, '6', 14, 1)); | |||
|
|
|||
| $this->assertSame(85916308548.27832, $uuid->getTime()); | |||
| $this->assertEquals(\DateTimeImmutable::createFromFormat('U.u', '85916308548.278321'), $uuid->getDateTime()); | |||
There was a problem hiding this comment.
This is a case where we are more precise now.
| $this->assertSame(-12219292800.0, ((new UuidV1('00000000-0000-1000-a456-426655440000'))->getTime())); | ||
| $this->assertEquals(\DateTimeImmutable::createFromFormat('U.u', '103072857660.684697'), ((new UuidV1('ffffffff-ffff-1fff-a456-426655440000'))->getDateTime())); | ||
| $this->assertEquals(\DateTimeImmutable::createFromFormat('U.u', '0.000001'), ((new UuidV1('1381400a-1dd2-11b2-a456-426655440000'))->getDateTime())); | ||
| $this->assertEquals(new \DateTimeImmutable('@0'), (new UuidV1('13814001-1dd2-11b2-a456-426655440000'))->getDateTime()); |
There was a problem hiding this comment.
This is a case where we are less precise now (0.0000001 is floored to 0.000000, ie 0).
1587c03 to
1023e26
Compare
1023e26 to
360c900
Compare
nicolas-grekas
approved these changes
Jan 27, 2021
|
Thank you @fancyweb. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting a
\DateTimeImmutablehas two benefits: easier to use and no float precision problems.There is however one drawback for UUIDs: we technically loose some precision in the output because datetimes do not handle nanoseconds (only microseconds) and uuid timestamps increment every 100 nanoseconds (0.1 microseconds). However, this is theoretical since the increment is only there to generate more entropy. Also, if an end user really want the precision, he can still do the conversion him/herself from the raw data. Finally, because of some rounding problems with floats even on 64b platforms, precision is actually won most of the time thanks to the datetime.
The idea is to also accept
\DateTimeInterfaceas input inUuidFactoryandUlidFactory(see #39507) btw.The breaking change is allowed because the component is experimental.