[DoctineBridge] Remove UuidV*Generator classes #40029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7065aa to
1caf80e
Compare
jderusse
approved these changes
Jan 28, 2021
OskarStark
approved these changes
Jan 29, 2021
OskarStark
reviewed
Jan 29, 2021
1caf80e to
3c296bd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no benefit in using these classes over creating the UUIDs inline.
Let's keep things simple.
For
UlidGenerator, I'm keeping it as it will provide something useful once #39507 and doctrine/DoctrineBundle#1284 are finished.