Skip to content

[HttpFoundation] Fix consistency in sessions not found exceptions #40114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2021
Merged

[HttpFoundation] Fix consistency in sessions not found exceptions #40114

merged 1 commit into from
Feb 11, 2021

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Feb 6, 2021

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40112
License MIT
Doc PR -

Make Request::getSession thrown a SessionNotFoundException and make SessionNotFoundException extends \BadMethodCallException for backward compatibility and

@jderusse jderusse mentioned this pull request Feb 6, 2021
Closed
@jderusse jderusse added this to the 5.x milestone Feb 6, 2021
Nyholm
Nyholm requested changes Feb 6, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just one question.

@jderusse jderusse force-pushed the session-consistency branch 2 times, most recently from 621ebcf to 072e4d7 Compare February 8, 2021 22:20
@carsonbot carsonbot changed the title Fix consistency in sessions not found exceptions [HttpFoundation] Fix consistency in sessions not found exceptions Feb 9, 2021
nicolas-grekas
nicolas-grekas reviewed Feb 11, 2021
View reviewed changes
@jderusse jderusse force-pushed the session-consistency branch from 072e4d7 to bf29b17 Compare February 11, 2021 10:28
nicolas-grekas
nicolas-grekas reviewed Feb 11, 2021
View reviewed changes
@jderusse jderusse force-pushed the session-consistency branch from bf29b17 to 7fcb76d Compare February 11, 2021 11:50
@derrabus
Copy link
Member

Thank you Jérémy.

@derrabus derrabus merged commit 1f067bc into symfony:5.x Feb 11, 2021
@ro0NL ro0NL mentioned this pull request Feb 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro0NL ro0NL ro0NL left review comments

@Nyholm Nyholm Nyholm requested changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Ready Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[HttpFoundation] Sync session not found exception
6 participants
@jderusse @derrabus @nicolas-grekas @ro0NL @Nyholm @carsonbot