Skip to content

[DependencyInjection] Add ContainerBuilder::willBeAvailable() to help with conditional configuration #40140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

[DependencyInjection] Add ContainerBuilder::willBeAvailable() to help with conditional configuration #40140

merged 1 commit into from
Feb 25, 2021

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Feb 9, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #40136, fix #39356
License MIT
Doc PR no need to

Leverages composer/composer#9682 to ignore dev-packages when configuring the container.

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Feb 9, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 9, 2021
Closed
@nicolas-grekas nicolas-grekas force-pushed the composer-installed branch 3 times, most recently from 99c5694 to 3d6ec73 Compare February 9, 2021 15:33
@nicolas-grekas nicolas-grekas changed the title [DependencyInjection] Add ContainerBuilder::isInstalled() to help with conditional configuration [DependencyInjection] Add ContainerBuilder::isAvailable() to help with conditional configuration Feb 9, 2021
@nicolas-grekas nicolas-grekas force-pushed the composer-installed branch 2 times, most recently from 4d42dfe to bf4ca77 Compare February 9, 2021 15:45
@nicolas-grekas nicolas-grekas changed the title [DependencyInjection] Add ContainerBuilder::isAvailable() to help with conditional configuration [DependencyInjection] Add ContainerBuilder::willBeAvailable() to help with conditional configuration Feb 9, 2021
@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Feb 9, 2021 •
edited
Loading

I renamed the method willBeAvailable() to hint that this is for checking the availability of symbols at runtime, not compile time.

@stof
Copy link
Member

stof commented Feb 9, 2021

that's indeed a good idea. But then, please check my review even if it is on an outdated diff due to the renaming.

@nicolas-grekas nicolas-grekas force-pushed the composer-installed branch 4 times, most recently from 54bc097 to 6288dca Compare February 10, 2021 09:38
@nicolas-grekas nicolas-grekas force-pushed the composer-installed branch 3 times, most recently from c8331fe to 5fdc1fc Compare February 16, 2021 10:55
@stof stof mentioned this pull request Feb 18, 2021
Closed
@nicolas-grekas nicolas-grekas force-pushed the composer-installed branch 2 times, most recently from 60612a7 to 6f6e66f Compare February 18, 2021 10:41
@chalasr
Copy link
Member

chalasr commented Feb 24, 2021

Rebase needed

@stof stof mentioned this pull request Feb 24, 2021
Merged
3 tasks
@nicolas-grekas nicolas-grekas merged commit 1849b57 into symfony:5.x Feb 25, 2021
@nicolas-grekas nicolas-grekas deleted the composer-installed branch February 25, 2021 16:14
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
GuilhemN added a commit to nelmio/NelmioApiDocBundle that referenced this pull request Jun 7, 2021
@GuilhemN
Explictly enable property access in the tests (related to symfony/sym…
d8a7859 
…fony#40140, it is a dev dependency)
@wuchen90 wuchen90 mentioned this pull request Jun 9, 2021
Closed
wouterj added a commit to wouterj/WouterJEloquentBundle that referenced this pull request Jun 13, 2021
@wouterj
Explicitly enable property access (ref symfony/symfony#40140)
711df01
wouterj added a commit to wouterj/WouterJEloquentBundle that referenced this pull request Jun 13, 2021
@wouterj
Explicitly enable/disable core Symfony integrations (ref symfony/symf…
164ba5a 
…ony#40140)
GuilhemN added a commit to nelmio/NelmioApiDocBundle that referenced this pull request Jun 14, 2021
@GuilhemN
Explictly enable property access in the tests (related to symfony/sym…
305668a 
…fony#40140, it is a dev dependency)
@wuchen90 wuchen90 mentioned this pull request Jun 17, 2021
Closed
@derrabus derrabus mentioned this pull request Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@ro0NL ro0NL ro0NL left review comments

@stof stof stof approved these changes

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
DependencyInjection Feature Ready Status: Reviewed
Projects
None yet
Milestone
5.4
6 participants
@nicolas-grekas @stof @chalasr @OskarStark @ro0NL @carsonbot