Skip to content

[Filesystem] improve messages on failure #40143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2021
Merged

[Filesystem] improve messages on failure #40143

merged 1 commit into from
Feb 11, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Feb 10, 2021
Nyholm
Nyholm reviewed Feb 11, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@derrabus derrabus mentioned this pull request Feb 11, 2021
Merged
@derrabus
Copy link
Member

Thank you Nicolas.

@derrabus derrabus merged commit f2f880a into symfony:5.x Feb 11, 2021
fabpot added a commit that referenced this pull request Feb 12, 2021
@fabpot
minor #40157 Modernize func_get_args() calls to variadic parameters (…
79ccf88 
…derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

Modernize func_get_args() calls to variadic parameters

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

While reviewing #40143, I stumbled across the `Filesystem::box()` method and I felt like we could make the code look a little less PHP5-ish.

Commits
-------

5b53613 Modernize func_get_args() calls to variadic parameters
@nicolas-grekas nicolas-grekas deleted the fs-better-msgs branch February 15, 2021 09:27
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm left review comments

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@jderusse jderusse jderusse approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Filesystem Ready Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @derrabus @javiereguiluz @jderusse @Nyholm @carsonbot