Skip to content

Fix: Article #40180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2021
Merged

Fix: Article #40180

merged 1 commit into from
Feb 15, 2021

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Feb 14, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

This pull request

  • fixes usages of the indefinite article a where an should be used instead

@carsonbot carsonbot added this to the 4.4 milestone Feb 14, 2021
@carsonbot carsonbot changed the title [Translation] Fix: Article [Translator] Fix: Article Feb 14, 2021
@localheinz localheinz changed the title [Translator] Fix: Article [Translation] Fix: Article Feb 14, 2021
@localheinz localheinz changed the title [Translation] Fix: Article [Translator] Fix: Article Feb 14, 2021
wouterj
wouterj approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I pronounce this as "cliff", which would indicate "a" instead of "an".

However, looking at the XLIFF spec, they use "an XLIFF document" (except from 1 occasion, I guess that's a typo). So 👍

@localheinz localheinz mentioned this pull request Feb 14, 2021
Merged
1 task
@localheinz localheinz changed the title [Translator] Fix: Article Fix: Article Feb 14, 2021
@carsonbot carsonbot changed the title Fix: Article [Translator] Fix: Article Feb 14, 2021
@localheinz
Copy link
Contributor Author

@wouterj

There are more cases which I have adjusted as well.

@localheinz localheinz force-pushed the fix/article branch 3 times, most recently from ed28a52 to d523202 Compare February 14, 2021 12:27
@localheinz localheinz changed the title [Translator] Fix: Article Fix: Article Feb 14, 2021
@localheinz localheinz requested a review from wouterj February 14, 2021 12:33
@localheinz
Copy link
Contributor Author

Issues reported by fabbot.io appear to be unrelated.

@carsonbot carsonbot changed the title Fix: Article [Translator] Fix: Article Feb 14, 2021
@chalasr chalasr changed the title [Translator] Fix: Article Fix: Article Feb 14, 2021
@localheinz localheinz mentioned this pull request Feb 15, 2021
Closed
@xabbuh
Copy link
Member

xabbuh commented Feb 15, 2021

Thank you Andreas.

@xabbuh xabbuh merged commit 4ee48c4 into symfony:4.4 Feb 15, 2021
@localheinz localheinz deleted the fix/article branch February 15, 2021 12:31
@localheinz
Copy link
Contributor Author

Thank you, @chalasr and @xabbuh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed Translation
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@localheinz @xabbuh @wouterj @chalasr @carsonbot