[PasswordHasher] Fix: Run 'php-cs-fixer fix' #40182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35d9969 to
75acf89
Compare
|
@localheinz Can you please rebase on the current 5.x branch? That should fix the remaining fabbot issues |
75acf89 to
2102170
Compare
chalasr
approved these changes
Feb 14, 2021
|
What is the usual policy here in regard to coding standard issues? Looks like
|
|
Honestly, I'm not sure to know how it works exactly :/ |
|
Thank you again Andreas! |
|
Thank you, @chalasr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
php-cs-fixer fixinsrc/Symfony/Component/PasswordHasher💁♂️ I do not know who or what enforces coding standard issues in this repository, but after opening a few pull requests in this repository, I noticed that
fabbot.iorepeatedly reports coding standard violations that are unrelated to the proposed changes. As an experiment I ranon the entire repository and found a lot of issues. Not sure, would you not prefer to have these fixed?
Since the
PasswordHashercomponent was only recently extracted, I assume it is safe to propose to runphp-cs-fixer fixat least on this newly introduced component.