Skip to content

Fix: Run 'php-cs-fixer fix' in 4.4 #40197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix: Run 'php-cs-fixer fix' in 4.4 #40197

wants to merge 1 commit into from

Conversation

localheinz
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Related to #40196
License MIT
Doc PR n/a

This pull request

@carsonbot carsonbot added this to the 4.4 milestone Feb 15, 2021
@localheinz localheinz mentioned this pull request Feb 15, 2021
Closed
@nicolas-grekas
Copy link
Member

Hello @localheinz
Thank you for the issue and the PR, but as you can read in the code, the CS of those files is as expected.
Yes, we could spend more time in finding a way to make running php-cs-fixer on the codebase fully "green".
But in practice, dealing with these divergences from the rules does not cost us much in terms of maintenance, and focusing on that aspect of the codebase doesn't provide much added value.
That's why we never cared too much.
I'm going to close here as obviously this is not correct (eg it breaks PHP 5.5 support on the phpunit-bridge).

@localheinz
Copy link
Contributor Author

@nicolas-grekas

Please take a look at #40196.

This pull request serves only to demonstrate that the current process is broken.

@localheinz localheinz deleted the fix/php-cs-fixer-in-4.4 branch February 15, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@sroze sroze Awaiting requested review from sroze

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@localheinz @nicolas-grekas @carsonbot