[ErrorHandler] Fix error caused by include + open_basedir
#40242
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
includeinclude
includeinclude
includeinclude
22c8eb9 to
3388bb3
Compare
includeinclude
|
Hey! I see that more good work is coming your way. I think @awoimbee has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
3388bb3 to
15a001b
Compare
includeinclude + open_basedir
15a001b to
9ad7832
Compare
|
Thank you @stlrnz. |
|
Only just seen this. Sorry that my implementation of #37492 caused issued, and thank you for fixing it :) |
#37492 introduced the option to specify your own error template using
HtmlErrorRenderer::setTemplate('...');However, the implementation using
file_exists(...)inincludecan cause an error when not setting a custom template.As you can see the error is caused by checking
file_exists(...)using relative paths in environments with a restrictiveopen_basedirpolicy.The proposed solution always uses absolute paths to include errors templates (and other files).