Deprecate passing null as $message or $code to exceptions #40288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shouldn't we apply the code turning |
|
@stof see reasoning in #40271 (comment) |
src/Symfony/Component/Config/Exception/FileLoaderImportCircularReferenceException.php
Outdated
Show resolved
Hide resolved
880d9e3 to
dbbbec1
Compare
dbbbec1 to
8e3058d
Compare
nicolas-grekas
approved these changes
Feb 24, 2021
fabpot
approved these changes
Feb 25, 2021
|
Thank you @derrabus. |
Merged
derrabus
added a commit
that referenced
this pull request
May 20, 2021
This PR was merged into the 5.3 branch. Discussion ---------- Add missing dependency | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Add missing dependency related to #40288 Commits ------- bd3c1fa Add missing dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #40271.
Following the example of the PHP core, this PR introduces deprecation warnings that are triggered if a developer attempts to pass null as
$codeor$messageto an exception constructor.