Skip to content

[HttpClient] Add HttpClientInterface::withOptions() #40306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

[HttpClient] Add HttpClientInterface::withOptions() #40306

merged 1 commit into from
Feb 25, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

I've been thinking about this method for a few months already.
We miss a way to configure an HTTP client in a generic way.
This is useful when eg building an API client as this allows configuring default options once for a consumer, eg in the constructor.

$this->client = $client->withOptions(['base_uri' => 'https://...']);

// [...]

$response = $this->client->request('GET', '/relative-url');

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Feb 25, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 25, 2021
Merged
10 tasks
Nyholm
Nyholm approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the implementation. I think it is a good thing that the withOptions() is implemented in a way to keep the HttpClient immutable.

I can also see that this is useful in third party code.

@nicolas-grekas nicolas-grekas merged commit d9dedb4 into symfony:5.x Feb 25, 2021
@nicolas-grekas nicolas-grekas deleted the hc-with-options branch February 25, 2021 17:54
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 25, 2021
Closed
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
@guilliamxavier guilliamxavier mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emancypage emancypage emancypage left review comments

@welcoMattic welcoMattic welcoMattic approved these changes

@Nyholm Nyholm Nyholm approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature HttpClient Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @welcoMattic @Nyholm @chalasr @emancypage @carsonbot