[Cache] boost perf by wrapping keys validity checks with assert()
#40317
Conversation
|
While I applaud perf increases, I have seen my fair share real life cases of caching systems which gave errors when NULL cache keys were being generated. The error was iirc thrown by the memcached adapter, and quite a pain to troubleshoot, as it carried no info whatsoever as to the offending bit of code. |
|
@gggeek I'd be fine throwing a Would you mind sending a PR doing so ? |
PSR-6 has one perf hog: checking the validity of keys.
But in practice, an invalid key should never happen in production: encoding/cleanup is a must-have, and it's a step that should be identified during dev.
That's why I think we're safe wrapping these checks with
assert().On an
ArrayAdapter, this doubles the throughput of the pool when getting items.I didn't use
assert()in constructors when not on the hot path.This PR also makes some callable properties static, as they should be from the beginning.