[FrameworkBundle] Monitor added/removed translations files in dev #4036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -507,6 +507,9 @@ private function registerTranslatorConfiguration(array $config, ContainerBuilder | |||
|
|
|||
| // Register translation resources | |||
| if ($dirs) { | |||
| foreach ($dirs as $dir) { | |||
| $container->addResource(new FileResource($dir)); | |||
There was a problem hiding this comment.
@vicb Shouldn't it be a DirectoryReource instead?
There was a problem hiding this comment.
Not sure about the behaviour of filemtime with directories but I'm not sure it will return the date of the last modified file inside.
There was a problem hiding this comment.
It worked when I tested but I didn't test nested folders which might require this. thanks for the hint.
|
maybe you also can fix #971 ? |
fabpot
added a commit
that referenced
this pull request
Apr 20, 2012
Commits ------- 7ddc8cb [FrameworkBundle] Monitor added/removed translations files in dev (fix #3653) Discussion ---------- [FrameworkBundle] Monitor added/removed translations files in dev fix #3653 --------------------------------------------------------------------------- by Koc at 2012-04-20T14:09:55Z maybe you also can fix #971 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3653