Skip to content

[Security] Re-add accidentally removed property declarations #40367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2021
Merged

[Security] Re-add accidentally removed property declarations #40367

merged 1 commit into from
Mar 5, 2021

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Mar 5, 2021

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

spotted while playing with psalm locally, mistake made in #39802

@chalasr chalasr requested a review from wouterj as a code owner March 5, 2021 09:27
@chalasr chalasr changed the title [Security] Readd accidentally removed property declarations [Security] Re-add accidentally removed property declarations Mar 5, 2021
@chalasr chalasr added this to the 5.x milestone Mar 5, 2021
@chalasr chalasr force-pushed the sec-missing-prop-declar branch from d5db4f7 to bccf736 Compare March 5, 2021 09:30
@chalasr chalasr merged commit c656ef9 into symfony:5.x Mar 5, 2021
@chalasr chalasr deleted the sec-missing-prop-declar branch March 5, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @xabbuh @carsonbot