[Notifier] [OvhCloud] Add "sender" #40377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "sender" option that allows configuring the sender of the message
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
OskarStark
reviewed
Mar 5, 2021
OskarStark
reviewed
Mar 5, 2021
OskarStark
reviewed
Mar 5, 2021
src/Symfony/Component/Notifier/Bridge/OvhCloud/OvhCloudTransport.php
Outdated
Show resolved
Hide resolved
OskarStark
requested changes
Mar 5, 2021
OskarStark
reviewed
Mar 6, 2021
src/Symfony/Component/Notifier/Bridge/OvhCloud/Tests/OvhCloudTransportTest.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Mar 6, 2021
|
Thank you @notFloran. |
fabpot
added a commit
that referenced
this pull request
Mar 6, 2021
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Notifier] [OvhCloud] Add "sender" | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> (I'm waiting to see if the feature is accepted ) Add "sender" option to the DSN that allows configuring the sender of the message. OVHCloud manages two cases for sending sms according to the [doc](https://docs.ovh.com/fr/sms/envoyer_des_sms_avec_lapi_ovh_en_php/): > The senderForResponse parameter will allow the use of a short number, which allows you to send SMS directly without having to create an alphanumeric sender (for example: your name). > Short numbers also allow you to receive responses from the recipients of your SMS, which can be useful for a satisfaction survey, a voting application, a game, etc.  This PR introduces the management of these 2 cases with a new option `sender`: * if `sender` is set, we use it * if `sender` is not set, we use `senderForResponse` to get a short number (current behavior) I took the logic implementedin the old official SDK : https://github.com/ovh/php-ovh-sms/blob/52d279e112a7da8f897745acab32a887321e03f1/src/Message.php#L161 Commits ------- c5a9b25 [Notifier] [OvhCloud] Add "sender"
fabpot
approved these changes
Mar 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "sender" option to the DSN that allows configuring the sender of the message.
OVHCloud manages two cases for sending sms according to the doc:
This PR introduces the management of these 2 cases with a new option
sender:senderis set, we use itsenderis not set, we usesenderForResponseto get a short number (current behavior)I took the logic implementedin the old official SDK : https://github.com/ovh/php-ovh-sms/blob/52d279e112a7da8f897745acab32a887321e03f1/src/Message.php#L161