[DependencyInjection][Security] Backport psr/container 1.1/2.0 compatibility #40386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1a4987 to
0814e29
Compare
chalasr
approved these changes
Mar 5, 2021
0814e29 to
dc9f364
Compare
nicolas-grekas
approved these changes
Mar 5, 2021
dc9f364 to
7f8242e
Compare
|
Update: PR title and commit message mentioned the wrong PSR package. 😓 |
stof
approved these changes
Mar 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports a fix that I had to apply to the 5.x branch in order to make it compatible with the
psr/container1.1 interfaces.It also updates various composer.json files:
ContainerInterfacewithout providing its own implementation. I should be compatible with version 2 of the PSR package already.DependencyInjection breaks on PHP 7.2 and 7.3 ifpsr/container1.1.0 is installed. A version 1.1.1 has already been release that fixes the issue. I've added a conflict rule to document the incompatibility.