-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[twig-bridge] Allow NotificationEmail to be marked as public #40448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
What do you think about "noPriority()" instead? |
@fabpot what do you think? |
@OskarStark I went with the same wording that the |
@OskarStark Seems good enough to me. |
Thank you @maxailloud. |
20c499a
to
8f753d2
Compare
You're welcome. Thank you too both for your work. |
Closes #37879
NotificationEmail
can be created public from theasPublicEmail
method in any context but with the Notifier component. In this case it is created by it as not public and therefore displays the importance in the subject of the email.For end users, aka not admin, the importance in the subject's email is not necessary.
This PR will allow if needed to set a
NotificationEmail
as public even after being created, wherever it was created.I am not sure how to handle the version in the changelog.
For the tests I don't know what's the policy so I just added a new case in each test case.