Skip to content

[twig-bridge] Allow NotificationEmail to be marked as public #40448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

maxailloud
Copy link
Contributor

Q A
Branch? 5.x for features
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #37879
License MIT
Doc PR -

Closes #37879

NotificationEmail can be created public from the asPublicEmail method in any context but with the Notifier component. In this case it is created by it as not public and therefore displays the importance in the subject of the email.
For end users, aka not admin, the importance in the subject's email is not necessary.
This PR will allow if needed to set a NotificationEmail as public even after being created, wherever it was created.

I am not sure how to handle the version in the changelog.
For the tests I don't know what's the policy so I just added a new case in each test case.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark
Copy link
Contributor

OskarStark commented Mar 11, 2021

What do you think about "noPriority()" instead?

@OskarStark
Copy link
Contributor

OskarStark commented Mar 11, 2021

@fabpot what do you think?
I have mixed feelings, but the need to implement a class to fix this is userland doesn't feel right to me either 🧐

@maxailloud
Copy link
Contributor Author

maxailloud commented Mar 11, 2021

@OskarStark I went with the same wording that the asPublicEmail static method of the class is using.
But happy to change it to something different if you think it fits better the result.

@fabpot
Copy link
Member

fabpot commented Mar 12, 2021

@OskarStark Seems good enough to me.

@fabpot
Copy link
Member

fabpot commented Mar 12, 2021

Thank you @maxailloud.

@maxailloud
Copy link
Contributor Author

You're welcome.

Thank you too both for your work.

@fabpot fabpot mentioned this pull request Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notifier] Add easier way to remove Importance from EmailNotification Subject
4 participants