Skip to content

[Security] Remove deprecated support for passing a UserInterface implementation to Passport #40487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Mar 16, 2021

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

In #37846 (review) , we agreed to have a deprecation path of only one minor release as the Passport feature is still experimental.

@wouterj wouterj requested a review from chalasr as a code owner March 16, 2021 12:52
@wouterj wouterj changed the title [Security] Disallow passing a UserInterface to Passport [Security] Remove deprecated support for passing a UserInterface implementation to Passport Mar 16, 2021
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Rebase needed though

This was deprecated in 5.2, with a warning that support would be dropped in 5.3
(due to the experimental state).
@fabpot fabpot force-pushed the pr-37846/remove-deprecation branch from 7884f97 to 99cf2a3 Compare March 17, 2021 06:03
@fabpot
Copy link
Member

fabpot commented Mar 17, 2021

Thank you @wouterj.

@fabpot fabpot merged commit 2c37d6f into symfony:5.x Mar 17, 2021
@wouterj wouterj deleted the pr-37846/remove-deprecation branch March 17, 2021 07:28
@fabpot fabpot mentioned this pull request Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants