Skip to content

[Yaml] fix parsing some block sequences #40503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

[Yaml] fix parsing some block sequences #40503

merged 1 commit into from
Apr 1, 2021

Conversation

a1812
Copy link
Contributor

@a1812 a1812 commented Mar 17, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40438
License MIT
Doc PR

@a1812 a1812 requested a review from xabbuh as a code owner March 17, 2021 18:20
@carsonbot carsonbot added this to the 4.4 milestone Mar 17, 2021
@nicolas-grekas nicolas-grekas changed the title Bug#40438 [Yaml] parses some block sequences Mar 17, 2021
@nicolas-grekas nicolas-grekas changed the title [Yaml] parses some block sequences [Yaml] fix parsing some block sequences Mar 17, 2021
stloyd
stloyd suggested changes Mar 17, 2021
View reviewed changes
@carsonbot carsonbot changed the title [Yaml] fix parsing some block sequences fix parsing some block sequences Mar 17, 2021
@a1812 a1812 changed the title fix parsing some block sequences [Yaml] fix parsing some block sequences Mar 18, 2021
@a1812 a1812 mentioned this pull request Mar 18, 2021
Closed
@a1812 a1812 force-pushed the bug#40438 branch 2 times, most recently from 56f32f5 to 590c94f Compare March 23, 2021 01:51
@a1812
Copy link
Contributor Author

a1812 commented Mar 25, 2021

Hi @xabbuh please check my super code :)

@xabbuh
Copy link
Member

xabbuh commented Mar 26, 2021 •
edited
Loading

Wow, this looks great @a1812! 👍 I have some suggestions how to simplify the patch a bit. Please take a look at a1812#1 if you agree with them.

@carsonbot carsonbot changed the title [Yaml] fix parsing some block sequences fix parsing some block sequences Mar 26, 2021
@carsonbot carsonbot changed the title fix parsing some block sequences [Yaml] fix parsing some block sequences Apr 1, 2021
@nicolas-grekas
Copy link
Member

Thank you @a1812.

@nicolas-grekas nicolas-grekas merged commit 4e4cdf5 into symfony:4.4 Apr 1, 2021
@brandonkelly brandonkelly mentioned this pull request Apr 2, 2021
Closed
@fabpot fabpot mentioned this pull request May 1, 2021
Merged
@fabpot fabpot mentioned this pull request May 1, 2021
Merged
@a1812 a1812 deleted the bug#40438 branch July 21, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@stloyd stloyd stloyd requested changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@a1812 @xabbuh @nicolas-grekas @stloyd @OskarStark @carsonbot