Skip to content

[Uid] Handle predefined namespaces keywords "dns", "url", "oid" and "x500" #40530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2021
Merged

[Uid] Handle predefined namespaces keywords "dns", "url", "oid" and "x500" #40530

merged 1 commit into from
Mar 23, 2021

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Mar 21, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

Before: uuid:generate --name-based="https://symfony.com" --namespace=6ba7b811-9dad-11d1-80b4-00c04fd430c8
After: uuid:generate --name-based="https://symfony.com" --namespace=url

Same for FWB configuration.

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Mar 21, 2021
@fancyweb fancyweb force-pushed the uid/uuid-generate-prefined-namespace-shortcut branch from dff069a to 59dc0ca Compare March 21, 2021 13:27
@fancyweb fancyweb changed the title [Uid] [GenerateUuidCommand] Add predefined namespaces keywords "dns", "url", "oid" and "x500" as valid input for the --namespace option [Uid] Handle predefined namespaces keywords "dns", "url", "oid" and "x500" Mar 21, 2021
@fancyweb fancyweb force-pushed the uid/uuid-generate-prefined-namespace-shortcut branch from 59dc0ca to 4ea3eef Compare March 21, 2021 13:29
@fancyweb fancyweb force-pushed the uid/uuid-generate-prefined-namespace-shortcut branch from 4ea3eef to 5f2bc27 Compare March 21, 2021 16:23
fancyweb
fancyweb commented Mar 21, 2021
View reviewed changes
src/Symfony/Component/Uid/Factory/UuidFactory.php Outdated
return $namespace;
}

if ('dns' === $namespace) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch maybe?

@fancyweb fancyweb force-pushed the uid/uuid-generate-prefined-namespace-shortcut branch from 5f2bc27 to ede46ac Compare March 21, 2021 17:34
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas mentioned this pull request Mar 23, 2021
Closed
@nicolas-grekas nicolas-grekas merged commit 55bd7f4 into symfony:5.x Mar 23, 2021
@fancyweb fancyweb deleted the uid/uuid-generate-prefined-namespace-shortcut branch March 23, 2021 12:37
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed Uid
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @nicolas-grekas @fabpot @carsonbot