Skip to content

[WebLink] Remove symfony/http-foundation dependency #40542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Mar 22, 2021

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #40536
License MIT
Doc PR

Both me and @derrabus overlooked this.

@Nyholm Nyholm requested a review from dunglas as a code owner March 22, 2021 13:52
@Nyholm Nyholm changed the title [Webline] Bump symfony/http-foundation to 5.3 [Weblink] Bump symfony/http-foundation to 5.3 Mar 22, 2021
@Nyholm Nyholm added the WebLink label Mar 22, 2021
@carsonbot carsonbot changed the title [Weblink] Bump symfony/http-foundation to 5.3 [WebLink] Bump symfony/http-foundation to 5.3 Mar 22, 2021
@Nyholm
Copy link
Member Author

Nyholm commented Mar 22, 2021

With "deps=low", Security/Csrf installs the wrong commit from 5.x.

That is why Travis is red.

@stof
Copy link
Member

stof commented Mar 22, 2021

The title of the PR needs to be updated, as it does not describe what is done anymore

@derrabus derrabus changed the title [WebLink] Bump symfony/http-foundation to 5.3 [WebLink] Remove symfony/http-foundation dependency Mar 22, 2021
@derrabus
Copy link
Member

Good catch, thanks Tobias.

@derrabus derrabus merged commit 15764b4 into symfony:5.x Mar 22, 2021
@Nyholm
Copy link
Member Author

Nyholm commented Mar 22, 2021

Thank you

@Nyholm Nyholm deleted the weblink-rename branch March 22, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants