Skip to content

[Security] Move the badges resolution check to AuthenticatorManager #40567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

[Security] Move the badges resolution check to AuthenticatorManager #40567

merged 1 commit into from
Mar 24, 2021

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Mar 24, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no (BC breaks on experimental code)
Tickets Fixes #40491
License MIT
Doc PR -

@chalasr chalasr requested a review from wouterj as a code owner March 24, 2021 00:04
@chalasr chalasr mentioned this pull request Mar 24, 2021
Closed
@chalasr chalasr force-pushed the badge-res branch 9 times, most recently from c31cfe3 to cf0507d Compare March 24, 2021 00:37
@chalasr chalasr force-pushed the badge-res branch 3 times, most recently from 09cc884 to f1abfa1 Compare March 24, 2021 10:05
@chalasr chalasr force-pushed the badge-res branch 2 times, most recently from c6ed62b to c6296b8 Compare March 24, 2021 12:32
Nyholm
Nyholm approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Just a minor.

@Nyholm Nyholm requested a review from wouterj March 24, 2021 12:34
@chalasr chalasr merged commit 2dcf313 into symfony:5.x Mar 24, 2021
@chalasr chalasr deleted the badge-res branch March 24, 2021 14:59
@chalasr
Copy link
Member Author

chalasr commented Mar 24, 2021

Thanks everyone for the discussion and reviews.

@wouterj wouterj mentioned this pull request Apr 4, 2021
Merged
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@ro0NL ro0NL ro0NL approved these changes

@Nyholm Nyholm Nyholm approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Feature Security Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Move PassportInterface::checkIfCompletelyResolved to service layer?
6 participants
@chalasr @stof @wouterj @ro0NL @Nyholm @carsonbot