[FrameworkBundle][HttpKernel][TwigBridge] Add an helper to generate fragments URL #40575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Cool. Good work. To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
0141b44 to
ded6359
Compare
stof
reviewed
Mar 24, 2021
df1c1ff to
982ba87
Compare
nicolas-grekas
approved these changes
Mar 30, 2021
chalasr
reviewed
Mar 30, 2021
e6a3f55 to
5d29d76
Compare
|
Thank you @dunglas. |
derrabus
added a commit
that referenced
this pull request
Apr 6, 2021
…(dunglas) This PR was merged into the 5.3-dev branch. Discussion ---------- [FrameworkBundle] Fix fragment.uri_generator definition | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a | License | MIT | Doc PR | n/a Fix for a bug I introduced in #40575 (missing service). Commits ------- eaae450 [FrameworkBundle] Fix fragment.uri_generator definition
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new helper to generate raw fragment URL. Fragments will be useful to generate lazy frames with Symfony UX Turbo (symfony/ux#64). This will also be convenient when using hinclude, ESI etc in case you want full control over the generated HTML.
This is also more in sync with the new best practices we apply in the form component (generate the HTML by yourself instead of using Twig helpers hiding the HTML elements).
Example: