Skip to content

Uses the correct assignment action for console options depending if they are short or long #40593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2021
Merged

Uses the correct assignment action for console options depending if they are short or long #40593

merged 1 commit into from
Mar 26, 2021

Conversation

topikito
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40590
License MIT
Doc PR -

Checks if the option is short or long, and assigns the corresponding "glue" for the assignment.

@topikito topikito requested a review from chalasr as a code owner March 25, 2021 22:38
@carsonbot carsonbot added this to the 4.4 milestone Mar 25, 2021
@topikito topikito changed the title Fix/array input [Console] Uses the correct assignment action for console options depending if they are short or long Mar 25, 2021
Nyholm
Nyholm approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I agree with this.

@carsonbot carsonbot changed the title [Console] Uses the correct assignment action for console options depending if they are short or long Uses the correct assignment action for console options depending if they are short or long Mar 25, 2021
@chalasr
Copy link
Member

chalasr commented Mar 26, 2021

Thanks for fixing this bug @topikito.

@chalasr chalasr merged commit ffc34fa into symfony:4.4 Mar 26, 2021
This was referenced Mar 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@topikito @chalasr @Nyholm @carsonbot