Skip to content

[Config] Fixed support for nodes not extending BaseNode #40603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

[Config] Fixed support for nodes not extending BaseNode #40603

merged 1 commit into from
Apr 1, 2021

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Mar 27, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Too many times we assume that a NodeInterface extends BaseNode. This PR adds a small test with a new CustomNodeDefinition and CustomNode that implements NodeInterface.

@carsonbot carsonbot added this to the 4.4 milestone Mar 27, 2021
Nyholm
Nyholm commented Mar 27, 2021
View reviewed changes
Copy link
Member Author

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is easier to review if one hide whitespace changes:

https://github.com/symfony/symfony/pull/40603/files?w=1

@Nyholm Nyholm mentioned this pull request Mar 28, 2021
Merged
@Nyholm Nyholm requested a review from derrabus March 29, 2021 10:57
@nicolas-grekas
Copy link
Member

Thank you @Nyholm.

@nicolas-grekas nicolas-grekas merged commit bd90627 into symfony:4.4 Apr 1, 2021
This was referenced May 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro0NL ro0NL ro0NL left review comments

@jderusse jderusse jderusse approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Bug Config Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Nyholm @nicolas-grekas @jderusse @ro0NL @carsonbot