Fix InputBag deprecation #40614
Closed
Fix InputBag deprecation #40614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Mar 28, 2021
azjezz
reviewed
Mar 28, 2021
There was a problem hiding this comment.
👎 for this, the type of $value is going to change to string|Stringable in symfony 6.0, allowing other scalars now in the phpdoc is conflicting with this.
currently we allow scalars at runtime because we want to keep the deprecation "soft" ( since other parameter class used to accept mixed )
Closing then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about this PR but there is something wrong between the phpdoc, the deprecation check and the deprecation message. The deprecation message is talking about
stringvalue, but the deprecation is only thrown for non-scalar value.Since you made this comment #34363 (comment) @nicolas-grekas, please review this PR.