Skip to content

[Notifier] [FakeChat] Added the bridge #40647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2021
Merged

[Notifier] [FakeChat] Added the bridge #40647

merged 1 commit into from
Apr 6, 2021

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Mar 31, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#15171
Recipe PR symfony/recipes#928

This PR is based on #39949 but for chat messages instead of SMS.

@OskarStark OskarStark self-assigned this Mar 31, 2021
@OskarStark OskarStark mentioned this pull request Mar 31, 2021
Merged
@OskarStark OskarStark mentioned this pull request Mar 31, 2021
Closed
6 tasks
Nyholm
Nyholm reviewed Mar 31, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Apr 1, 2021
@nicolas-grekas
Copy link
Member

LICENSE and .git* files are missing

@OskarStark OskarStark force-pushed the notifier/fake-chat branch from 46e6f95 to b7ffa8d Compare April 1, 2021 09:57
@OskarStark
Copy link
Contributor Author

LICENSE and .git* files are missing

Thanks, fixed

@nicolas-grekas nicolas-grekas mentioned this pull request Apr 1, 2021
Merged
@OskarStark OskarStark force-pushed the notifier/fake-chat branch from b7ffa8d to a8ee94c Compare April 4, 2021 15:49
@OskarStark
Copy link
Contributor Author

Rebased

@OskarStark OskarStark force-pushed the notifier/fake-chat branch from e373164 to a08c0c1 Compare April 4, 2021 15:51
@OskarStark OskarStark requested a review from Nyholm April 5, 2021 09:44
@OskarStark OskarStark force-pushed the notifier/fake-chat branch from a08c0c1 to 0ce156c Compare April 6, 2021 10:38
@OskarStark
Copy link
Contributor Author

I merge this, as its mostly a copy paste from FakeSms bridge

@OskarStark OskarStark merged commit 345eb75 into symfony:5.x Apr 6, 2021
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Apr 6, 2021
@OskarStark
feature #15171 [Notifier] [FakeChat] add docs (OskarStark)
6fa9693 
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] [FakeChat] add docs

Docs for symfony/symfony#40647

Commits
-------

018d50b [Notifier][FakeChat] add docs
chalasr
chalasr reviewed Apr 8, 2021
View reviewed changes
src/Symfony/Component/Notifier/Bridge/FakeChat/FakeChatTransportFactory.php
{
protected $serviceProvider;

public function __construct(ServiceProviderInterface $serviceProvider)
Copy link
Member

@chalasr chalasr Apr 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #40731, where is this locator configured? The framework integration seems broken

@OskarStark OskarStark deleted the notifier/fake-chat branch April 8, 2021 10:51
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr left review comments

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees

@OskarStark OskarStark

Labels
Feature Notifier Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @nicolas-grekas @Nyholm @chalasr @carsonbot