Skip to content

[Yaml] Fixed infinite loop when parser goes through an additional and invalid closing tag #40707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexandre-daubois
Copy link
Member

Q A
Branch? 4.4 and above
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40706
License MIT
Doc PR

Instead of letting the parser goes in an infinite loop because it can't get the right closing tag, throw an exception when the additional and invalid closing tag is found

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

@alexandre-daubois alexandre-daubois force-pushed the fix-yaml-parser-infinite-loop-closing-tag branch from 08b1da9 to ccdf977 Compare April 5, 2021 10:15
… invalid closing tag

Instead of letting the parser goes in an infinite loop, throw an exception when the additional and invalid is found
@alexandre-daubois alexandre-daubois force-pushed the fix-yaml-parser-infinite-loop-closing-tag branch from ccdf977 to d5f8c88 Compare April 5, 2021 10:16
@alexandre-daubois alexandre-daubois requested a review from Nyholm April 8, 2021 12:09
@Nyholm
Copy link
Member

Nyholm commented Apr 9, 2021

Great work Alexandre. I appreciate all your PRs. Keep up the good work!

@Nyholm Nyholm merged commit ed576b2 into symfony:4.4 Apr 9, 2021
This was referenced May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants