-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
allow null for framework.translator.default_path #40744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
shouldnt we fix it at the Configuration level, given IIUC |
I see two options:
I am not sure which way to go. Actually it was a BC break in 3.4.x, which was not noticed quickly. For more details see #37111 |
i think it broke as of 4.x due the added type hint in ContainerBuilder::fileExists before the inexistence was implicit, eg. So i think allowing explicit |
Should I add a test case checking this config value? Where should I add it? I doubt that |
Allow to configure framework.translator.default_path to null, as it was until symfony 3.4.x (fix BC compatibility). fixes symfony#37111
Thank you @SimonHeimberg. |
Allow to configure framework.translator.default_path to null, as it was until symfony 3.4.x (fix BC compatibility).