[PhpUnitBridge] Fix phpunit symlink on Windows #40754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @ro0NL has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
nicolas-grekas
approved these changes
Apr 11, 2021
|
Thank you @johnstevenson. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the symlink to
.phpunit/phpunitalready exists, unlink is called to remove it. But this fails on Windows (because it is a directory and requiresrmdir), which in turn causes the subsequentsymlinkcall to fail (because it already exists).Additionally, creating symlinks on Windows requires Administrator permissions (generally), so
.phpunit/phpunitcan never be created for ordinary Users.This PR uses a junction instead of a symlink on Windows. It also fixes some issues with stderror output and adds some argument escaping.