[Routing] Fix localized paths #40767
Conversation
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
58ca2b4 to
1e20cd6
Compare
1e20cd6 to
67fd37f
Compare
src/Symfony/Component/Routing/Tests/Fixtures/AnnotationFixtures/FooController.php
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /** | ||
| * @Route({"requirements":{"locale":"en"}, "path":""}) |
There was a problem hiding this comment.
Okay, right. This does work now that we've enabled @NamedArgumentConstructor, but I'd consider this to be an accident rather than intended behavior. I would not build a test case for that.
There was a problem hiding this comment.
related to https://github.com/symfony/symfony/pull/40767/files#r612721813. This fixture is to test deprecation but maybe I misunderstand the target of the deprecation.
There was a problem hiding this comment.
The deprecation is not supposed to be triggered by normal annotation usage. The target are manual constructor calls (that should not happen anyway).
There was a problem hiding this comment.
Oh ok thank you. I pushed some changes :)
There was a problem hiding this comment.
Sorry, I used cs fixer with a wrong PHP version;it broke attributes. I'll fix it tomorrow.
d061b3d to
ec47816
Compare
4b97084 to
9bf4a24
Compare
|
status: needs review |
|
Hello, is there something to check related to this issue? I saw it wasn't shipped with 5.3 beta2. |
|
IIRC, we're only waiting for a second core team approval. |
|
Thank you @l-vo. |
Related to #40266, localized paths does not work anymore. This PR aims to fix that and add a rework on the tests (using real annotations/attributes instead of guessing the parsing that may lead to errors).