[DependencyInjection] Allow calling custom processors directly on EnvConfigurator #40779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add magic __call method to EnvConfigurator to allow calling custom processors as methods instead of using the custom method.
jvasseur
commented
Apr 12, 2021
| */ | ||
| public function __call(string $name, array $arguments): self | ||
| { | ||
| $processor = strtolower(preg_replace(['/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'], '\1_\2', $name)); |
There was a problem hiding this comment.
We could add a dependency on the string component instead here but not sure if it is worth it.
| { | ||
| $processor = strtolower(preg_replace(['/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'], '\1_\2', $name)); | ||
|
|
||
| $this->custom($processor, ...$arguments); |
There was a problem hiding this comment.
let's remove custom() instead, don't you think?
There was a problem hiding this comment.
I would prefer to use custom over magic methods.
fancyweb
approved these changes
Apr 12, 2021
nicolas-grekas
approved these changes
Apr 13, 2021
|
Thank you @jvasseur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposition of addition to the feature added by #40682 to allow calling custom processors in the same way we call builtin ones. This is not perfect since it doesn't allow auto-completion for these custom methods but I think this provides a cleaner API for custom processors.