[DoctrineBridge] Add support for a driver type "attribute" #40793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Apr 13, 2021
3a4a581 to
a5a14a4
Compare
Nyholm
reviewed
Apr 13, 2021
| @@ -193,6 +193,10 @@ protected function registerMappingDrivers($objectManager, ContainerBuilder $cont | |||
| $args[0] = array_merge(array_values($driverPaths), $args[0]); | |||
| } | |||
| $mappingDriverDef->setArguments($args); | |||
| } elseif ('attribute' === $driverType) { | |||
| $mappingDriverDef = new Definition('%'.$this->getObjectManagerElementName('metadata.'.$driverType.'.class%'), [ | |||
There was a problem hiding this comment.
Are you sure this line is correct?
I suggest to not concat $driverType.
So, should it really be:
new Definition('%'.$this->getObjectManagerElementName('metadata.attribute.class%')Or did you mean to write:
new Definition('%'.$this->getObjectManagerElementName('metadata.attribute.class').'%'There was a problem hiding this comment.
I copied that from the annotation code. Yours makes more sense, but the method returns the string , so the result is the same either way. I will clean this up.
|
This is a duplicate of symfony/doctrine-bridge#10 (but this one looks incomplete). |
a5a14a4 to
cecaa78
Compare
Nyholm
approved these changes
Apr 16, 2021
| @@ -437,7 +441,7 @@ protected function getMetadataDriverClass(string $driverType): string | |||
| { | |||
| @trigger_error(sprintf('Not declaring the "%s" method in class "%s" is deprecated since Symfony 4.4. This method will be abstract in Symfony 5.0.', __METHOD__, static::class), \E_USER_DEPRECATED); | |||
|
|
|||
| return '%'.$this->getObjectManagerElementName('metadata.'.$driverType.'.class%'); | |||
| return '%'.$this->getObjectManagerElementName('metadata.'.$driverType.'.class').'%'; | |||
chalasr
approved these changes
Apr 16, 2021
|
👍 |
|
Thank you everyone, this makes everything easier :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change its not possible to use attributes for mapping when they get released in ORM 2.9 over the next days. Otherwise we would need to copy three methods from the
AbstractDoctrineExtensioninto the Bundle. See the DoctrineBundle PR that makes the full changes: doctrine/DoctrineBundle#1322