RequestMatcher issue when _controller
is a closure
#40807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the
matches
method ofRequestMatcher
is used on an attribute which is a closure it crashes.How did we get it
On a project that is using FOS HTTP Cache, we have this configuration
Everything works fine unless you are reaching a controller that is a closure.
You get a
TypeError: preg_match(): Argument #2 ($subject) must be of type string, Closure given
which is to me logical.Proposed solution
Just testing the type of attribute value and return false before crashing
preg_match
This PR adds a quick unit test to enforce this.