Skip to content

Remove the experimental flag from the authenticator system 🚀 #40814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Bundle/SecurityBundle/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ CHANGELOG
5.3
---

* The authenticator system is no longer experimental
* Login Link functionality is no longer experimental
* Add `required_badges` firewall config option
* [BC break] Add `login_throttling.lock_factory` setting defaulting to `null` (instead of `lock.factory`)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

/**
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
interface AuthenticatorFactoryInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @internal
* @experimental in 5.3
*/
class CustomAuthenticatorFactory implements AuthenticatorFactoryInterface, SecurityFactoryInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
* Decorates {@see RememberMeHandlerInterface} for the current firewall.
*
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
final class FirewallAwareRememberMeHandler implements RememberMeHandlerInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class UserAuthenticator implements UserAuthenticatorInterface
{
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Ldap/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ CHANGELOG
5.3
---

* The authenticator system is no longer experimental
* Added caseSensitive option for attribute keys in the Entry class.

5.1.0
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/Ldap/Security/LdapAuthenticator.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.1
*/
class LdapAuthenticator implements AuthenticatorInterface
{
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/Ldap/Security/LdapBadge.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.1
*/
class LdapBadge implements BadgeInterface
{
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Security/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The CHANGELOG for version 5.4 and newer can be found in the security sub-package
5.3
---

* The authenticator system is no longer experimental
* Login Link functionality is no longer experimental
* Add `RememberMeConditionsListener` to check if remember me is requested and supported, and set priority of `RememberMeListener` to -63
* Add `RememberMeHandlerInterface` and implementations, used as a replacement of `RememberMeServicesInterface` when using the AuthenticatorManager
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
/**
* @author Ryan Weaver <ryan@symfonycasts.com>
*
* @experimental in 5.2
*
* @final
*/
final class ExpiredSignatureStorage
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
* @author Ryan Weaver <ryan@symfonycasts.com>
* @author Amaury Leroux de Lens <amaury@lerouxdelens.com>
*
* @experimental in 5.3
*/
class AuthenticatorManager implements AuthenticatorManagerInterface, UserAuthenticatorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
/**
* @author Wouter de Jong <wouter@wouterj.nl>
* @author Ryan Weaver <ryan@symfonycasts.com>
*
* @experimental in 5.3
*/
interface AuthenticatorManagerInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@

/**
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
interface UserAuthenticatorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
* An optional base class that creates the necessary tokens for you.
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*
* @experimental in 5.3
*/
abstract class AbstractAuthenticator implements AuthenticatorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
* A base class to make form login authentication easier!
*
* @author Ryan Weaver <ryan@symfonycasts.com>
*
* @experimental in 5.3
*/
abstract class AbstractLoginFormAuthenticator extends AbstractAuthenticator implements AuthenticationEntryPointInterface, InteractiveAuthenticatorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
* @author Fabien Potencier <fabien@symfony.com>
*
* @internal
* @experimental in 5.3
*/
abstract class AbstractPreAuthenticatedAuthenticator implements InteractiveAuthenticatorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
* @author Ryan Weaver <ryan@symfonycasts.com>
* @author Amaury Leroux de Lens <amaury@lerouxdelens.com>
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
interface AuthenticatorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,9 @@
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
use Symfony\Component\Security\Core\Exception\AuthenticationException;
use Symfony\Component\Security\Core\Exception\AuthenticationServiceException;
use Symfony\Component\Security\Core\Exception\BadCredentialsException;
use Symfony\Component\Security\Core\Security;
use Symfony\Component\Security\Core\User\PasswordUpgraderInterface;
use Symfony\Component\Security\Core\User\UserInterface;
use Symfony\Component\Security\Core\User\UserProviderInterface;
use Symfony\Component\Security\Http\Authentication\AuthenticationFailureHandlerInterface;
use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;
Expand All @@ -41,7 +39,6 @@
* @author Fabien Potencier <fabien@symfony.com>
*
* @final
* @experimental in 5.3
*/
class FormLoginAuthenticator extends AbstractLoginFormAuthenticator
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
use Symfony\Component\Security\Core\Exception\AuthenticationException;
use Symfony\Component\Security\Core\Exception\AuthenticationServiceException;
use Symfony\Component\Security\Core\User\PasswordUpgraderInterface;
use Symfony\Component\Security\Core\User\UserInterface;
use Symfony\Component\Security\Core\User\UserProviderInterface;
use Symfony\Component\Security\Http\Authenticator\Passport\Badge\PasswordUpgradeBadge;
use Symfony\Component\Security\Http\Authenticator\Passport\Badge\UserBadge;
Expand All @@ -33,7 +31,6 @@
* @author Fabien Potencier <fabien@symfony.com>
*
* @final
* @experimental in 5.3
*/
class HttpBasicAuthenticator implements AuthenticatorInterface, AuthenticationEntryPointInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,9 @@
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
use Symfony\Component\Security\Core\Exception\AuthenticationException;
use Symfony\Component\Security\Core\Exception\AuthenticationServiceException;
use Symfony\Component\Security\Core\Exception\BadCredentialsException;
use Symfony\Component\Security\Core\Security;
use Symfony\Component\Security\Core\User\PasswordUpgraderInterface;
use Symfony\Component\Security\Core\User\UserInterface;
use Symfony\Component\Security\Core\User\UserProviderInterface;
use Symfony\Component\Security\Http\Authentication\AuthenticationFailureHandlerInterface;
use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;
Expand All @@ -45,7 +43,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class JsonLoginAuthenticator implements InteractiveAuthenticatorInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
* Passport badges allow to add more information to a passport (e.g. a CSRF token).
*
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
interface BadgeInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class CsrfTokenBadge implements BadgeInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class PasswordUpgradeBadge implements BadgeInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class PreAuthenticatedUserBadge implements BadgeInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class RememberMeBadge implements BadgeInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
* "user loader" to load the related User object.
*
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
class UserBadge implements BadgeInterface
{
Expand Down Expand Up @@ -67,7 +65,7 @@ public function getUser(): UserInterface

$this->user = ($this->userLoader)($this->userIdentifier);
if (!$this->user instanceof UserInterface) {
throw new AuthenticationServiceException(sprintf('The user provider must return a UserInterface object, "%s" given.', \get_debug_type($this->user)));
throw new AuthenticationServiceException(sprintf('The user provider must return a UserInterface object, "%s" given.', get_debug_type($this->user)));
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
* credential check of an authenticator.
*
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
interface CredentialsInterface extends BadgeInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class CustomCredentials implements CredentialsInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class PasswordCredentials implements CredentialsInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
* The default implementation for passports.
*
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
class Passport implements UserPassportInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
* passport.
*
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
interface PassportInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

/**
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
trait PassportTrait
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
* API token authentication).
*
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
class SelfValidatingPassport extends Passport
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
* Represents a passport for a Security User.
*
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
interface UserPassportInterface extends PassportInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
* @author Fabien Potencier <fabien@symfony.com>
*
* @final
* @experimental in 5.3
*/
class X509Authenticator extends AbstractPreAuthenticatedAuthenticator
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
* @author Wouter de Jong <wouter@driveamber.com>
*
* @final
* @experimental in 5.3
*/
class CheckCredentialsListener implements EventSubscriberInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class CheckRememberMeConditionsListener implements EventSubscriberInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class CsrfProtectionListener implements EventSubscriberInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@

/**
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @experimental in 5.3
*/
final class LoginThrottlingListener implements EventSubscriberInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class PasswordMigratingListener implements EventSubscriberInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class RememberMeListener implements EventSubscriberInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
* @author Wouter de Jong <wouter@wouterj.nl>
*
* @final
* @experimental in 5.3
*/
class UserCheckerListener implements EventSubscriberInterface
{
Expand Down
Loading