[Form] Restored and deprecated method guessMinLength in FormTypeGuesser
#4085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,6 +115,13 @@ public function guessMaxLength($class, $property) | |||
| /** | |||
| * {@inheritDoc} | |||
| */ | |||
| public function guessMinLength($class, $property) | |||
There was a problem hiding this comment.
should be raise an E_USER_DEPRECATED for deprecated methods?
There was a problem hiding this comment.
no as we catch PHP notices to convert them to exceptions... except if we modify the error handling we have right now. But I'm not a big fan of PHP notices/warnings anyway as people don't really read them.
There was a problem hiding this comment.
I think it would be useful to show people in the profiler which deprecated methods they are using.
There was a problem hiding this comment.
I agree. Maybe add special handling for E_USER_DEPRECATED?
fabpot
added a commit
that referenced
this pull request
Apr 23, 2012
Commits ------- d9e142b [Form] Restored and deprecated method `guessMinLength` in FormTypeGuesser Discussion ---------- [Form] Restored and deprecated method `guessMinLength` in FormTypeGuesser Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: -  This is a follow-up PR to #4077 (see comments in #3927 for reference).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
This is a follow-up PR to #4077 (see comments in #3927 for reference).