Skip to content

[Config] Remove double semicolons from autogenerated config classes #40950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2021
Merged

[Config] Remove double semicolons from autogenerated config classes #40950

merged 1 commit into from
Apr 27, 2021

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Apr 26, 2021 •
edited by Nyholm
Loading

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR N/A

In some cases, the autogenerated config classes contain double semicolons:

image

@HypeMC HypeMC changed the title Remove double semicolons from autogenerated config classes [Config] Remove double semicolons from autogenerated config classes Apr 26, 2021
@derrabus derrabus added this to the 5.3 milestone Apr 26, 2021
@derrabus derrabus added the Bug label Apr 26, 2021
Nyholm
Nyholm approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

When I first wrote this I hoped that I could run php-cs-fixer on the generated result. But we took a different route.

@derrabus
Copy link
Member

Thank you @HypeMC.

@derrabus derrabus merged commit 5506f2a into symfony:5.x Apr 27, 2021
@HypeMC HypeMC deleted the config-double-semicolon branch April 27, 2021 12:17
@fabpot fabpot mentioned this pull request May 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Bug Config Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@HypeMC @derrabus @Nyholm @carsonbot