Skip to content

[FrameworkBundle] Make debug:event-dispatcher search case insensitive #40951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2021
Merged

[FrameworkBundle] Make debug:event-dispatcher search case insensitive #40951

merged 1 commit into from
Apr 29, 2021

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

I was playing with the new features of debug:event-dispatcher and I thought that making the new search feature case insensitive could be better:

Before

$ php bin/console debug:event-dispatcher mailer


 [WARNING] The event "mailer" does not have any registered listeners.

After

$ php bin/console debug:event-dispatcher mailer

Registered Listeners of Event Dispatcher "debug.event_dispatcher" for "Symfony\Component\Mailer\Event\MessageEvent" Event
=========================================================================================================================

 ------- --------------------------------------------------------------------------- ----------
  Order   Callable                                                                    Priority
 ------- --------------------------------------------------------------------------- ----------
  #1      Symfony\Component\Mailer\EventListener\MessageListener::onMessage()         0
  #2      Symfony\Component\Mailer\EventListener\EnvelopeListener::onMessage()        -255
  #3      Symfony\Component\Mailer\EventListener\MessageLoggerListener::onMessage()   -255
 ------- --------------------------------------------------------------------------- ----------

@javiereguiluz javiereguiluz added this to the 5.x milestone Apr 26, 2021
Nyholm
Nyholm approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I agree with this change.

It will make the event listeners easier to find.

@fabpot
Copy link
Member

fabpot commented Apr 29, 2021

Thank you @javiereguiluz.

@fabpot fabpot merged commit 1882d26 into symfony:5.x Apr 29, 2021
@javiereguiluz javiereguiluz deleted the debug_event_case branch April 29, 2021 13:19
@fabpot fabpot mentioned this pull request May 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Needs Work
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @fabpot @Nyholm @carsonbot