Skip to content

[FrameworkBundle] Fix the event debug command #40952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FrameworkBundle] Fix the event debug command #40952

wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Apr 26, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

In Symfony 5.3 (both beta1 and 5.x-dev) if you try to run debug:event-dispatcher command without arguments you see this error:

image

I run this:

$ php bin/console debug:container event_dispatcher

  // This service is a public alias for the service debug.event_dispatcher

  Information for Service "debug.event_dispatcher"
  ================================================

  Collects some data about event listeners.

  // ....

That's why I changed the service name to debug.event_dispatcher ... and the problem seems to be solved now.

@javiereguiluz javiereguiluz added this to the 5.3 milestone Apr 26, 2021
@derrabus
Copy link
Member

I can confirm the bug, I don't think that this is the right fix. event_dispatcher is the correct service ID for the default dispatcher and I would expect the command to work if I request that dispatcher explicitly:

./bin/console debug:event-dispatcher --dispatcher=event_dispatcher

But that does not work either and it's not fixed by changing the command's default.

@javiereguiluz javiereguiluz changed the title [FrameworkBundle] Fixed the default event dispatcher in event debug command [FrameworkBundle] Fix the event debug command Apr 30, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request May 10, 2021
Merged
@nicolas-grekas
Copy link
Member

Replaced by #41164, thanks for reporting.

nicolas-grekas added a commit that referenced this pull request May 10, 2021
@nicolas-grekas
bug #41164 [FrameworkBundle] fix debug:event-dispatcher and debug:fir…
18997ab 
…ewall (nicolas-grekas)

This PR was merged into the 5.3-dev branch.

Discussion
----------

[FrameworkBundle] fix debug:event-dispatcher and debug:firewall

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #40952
| License       | MIT
| Doc PR        | -

Commits
-------

83cd552 [FrameworkBundle] fix debug:event-dispatcher and debug:firewall
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @derrabus @nicolas-grekas @carsonbot