[TwigBridge] Fix HTML for translatable custom-file label in Bootstrap 4 theme #40980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
stof
reviewed
Apr 29, 2021
src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig
Outdated
Show resolved
Hide resolved
… 4 theme Bootstraps allows to translate the label of the button of a custom-file input with SCSS variables depending on the lang attribute of the *input*. This attribute was set on the label instead and thus had no effect.
nicolas-grekas
approved these changes
May 7, 2021
|
Thank you @acran. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap allows to translate/change the label of the upload button of a
custom-fileinput via SCSS, see Bootstrap docs:This works by generating the following CSS which depends on the
langattribute of the input:This however currently does not work with the HTML generated by the theme since the resulting HTML is of the form (redacted here to the relevant parts):
while it should be of the form
i.e. the
langwas placed on thelabelinstead of theinput.This PR fixes this to be compatible with Bootstrap 4.