Skip to content

[Notifier] Add SlackOptions::threadTs() to send message as reply #40992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

[Notifier] Add SlackOptions::threadTs() to send message as reply #40992

merged 1 commit into from
May 6, 2021

Conversation

WaylandAce
Copy link
Contributor

@WaylandAce WaylandAce commented Apr 29, 2021 •
edited by OskarStark
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets no
License MIT
Doc PR no

Allow specify argument thread_ts to send reply message.

@WaylandAce WaylandAce requested a review from OskarStark as a code owner April 29, 2021 17:26
OskarStark
OskarStark approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry, thanks

@WaylandAce
Copy link
Contributor Author

Please add a CHANGELOG entry, thanks

5.3 or 5.4?

@OskarStark
Copy link
Contributor

5.4 please

@WaylandAce WaylandAce force-pushed the feature/slack-notifier-thread_ts branch from a15312c to 1b713ae Compare April 30, 2021 09:06
@nicolas-grekas nicolas-grekas added this to the 5.x milestone May 1, 2021
@WaylandAce WaylandAce force-pushed the feature/slack-notifier-thread_ts branch from 1b713ae to 9a8d9c2 Compare May 5, 2021 07:29
@OskarStark OskarStark requested a review from nicolas-grekas May 6, 2021 18:35
@OskarStark OskarStark removed the request for review from nicolas-grekas May 6, 2021 18:35
@nicolas-grekas nicolas-grekas changed the title [Notifier] [Bridge] Add SlackOptions.thread_ts to allow reply messages [Notifier] Add SlackOptions::threadTs() to send message as reply May 6, 2021
@nicolas-grekas nicolas-grekas modified the milestones: 5.x, 5.3 May 6, 2021
@nicolas-grekas nicolas-grekas force-pushed the feature/slack-notifier-thread_ts branch from 9a8d9c2 to d3807a7 Compare May 6, 2021 19:01
@nicolas-grekas
Copy link
Member

Thank you @WaylandAce.

@nicolas-grekas nicolas-grekas merged commit ef2da6c into symfony:5.x May 6, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request May 6, 2021
Closed
@fabpot fabpot mentioned this pull request May 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Needs Review
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@WaylandAce @OskarStark @nicolas-grekas @carsonbot