Skip to content

[PasswordHasher] Improved BC layer #41022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

[PasswordHasher] Improved BC layer #41022

merged 1 commit into from
May 4, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented May 1, 2021 •
edited
Loading

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #41020, Fix #41024
License MIT
Doc PR N/A

@derrabus derrabus requested review from chalasr and wouterj as code owners May 1, 2021 18:10
@derrabus derrabus added this to the 5.3 milestone May 1, 2021
@derrabus derrabus force-pushed the bugfix/password-hasher-compat branch from dcde4e5 to 080eb14 Compare May 1, 2021 22:07
@derrabus derrabus changed the title [PasswordHasher] Fixed compatibility with existing password encoders [PasswordHasher] Improved BC layer May 1, 2021
@derrabus derrabus force-pushed the bugfix/password-hasher-compat branch from 080eb14 to 7a3aae4 Compare May 1, 2021 22:09
@derrabus derrabus force-pushed the bugfix/password-hasher-compat branch from 7a3aae4 to 0caad4f Compare May 2, 2021 11:09
@carsonbot
Copy link

Hey!

I think @localheinz has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

chalasr
chalasr approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for the patch,Alexander.

@derrabus derrabus merged commit 5483e11 into symfony:5.x May 4, 2021
@derrabus derrabus deleted the bugfix/password-hasher-compat branch May 4, 2021 17:56
@fabpot fabpot mentioned this pull request May 9, 2021
Merged
@peter17 peter17 mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Bug PasswordHasher Status: Reviewed
Projects
None yet
Milestone
5.3
4 participants
@derrabus @carsonbot @javiereguiluz @chalasr