Skip to content

[Cache] Check if phpredis version is compatible with stream parameter #41099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021

Conversation

nicolassing
Copy link
Contributor

@nicolassing nicolassing commented May 3, 2021

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
License MIT

If you use phpredis <5.3.0, you can't connect to Redis since symfony/cache 5.2.7

Fixes #41110

@nicolas-grekas
Copy link
Member

The issue happens on 4.4 also apparently. Can you please rebase+target for 4.4?
There might be another line to patch apparently, see f8518ca

/cc @jackthomasatl FYI

@nicolas-grekas nicolas-grekas reopened this May 5, 2021
@pwbzh
Copy link

pwbzh commented May 7, 2021

Hello, I have the same problem when I update to Symfony v4.4.22 from v4.4.21.
I fallback to v4.4.21.

Redis version: 5.0.7
PHP version : 7.4.3

@nicolas-grekas nicolas-grekas changed the base branch from 5.2 to 4.4 May 7, 2021 12:31
@nicolas-grekas nicolas-grekas force-pushed the fix/phpredis-version branch from d0d461b to f6bc471 Compare May 7, 2021 12:31
@nicolas-grekas nicolas-grekas force-pushed the fix/phpredis-version branch from f6bc471 to 841d85a Compare May 7, 2021 12:34
@nicolas-grekas
Copy link
Member

Thank you @nicolassing.

@nicolas-grekas nicolas-grekas merged commit ae38bda into symfony:4.4 May 7, 2021
This was referenced May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants