Skip to content

[TwigBridge] Add encore_entry_*_tags() to UndefinedCallableHandler, as no-op #41205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented May 12, 2021

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Turning them into no-ops to allow uncommenting them in the default base.html.twig

See symfony/recipes#948

/cc @weaverryan

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this!

@nicolas-grekas nicolas-grekas requested a review from weaverryan May 28, 2021 15:23
@nicolas-grekas
Copy link
Member Author

Any other +1 @symfony/mergers?

@fabpot
Copy link
Member

fabpot commented Jun 23, 2021

Thank you @nicolas-grekas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants